Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set clockskew to 10 seconds #93

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Set clockskew to 10 seconds #93

merged 3 commits into from
Apr 25, 2024

Conversation

HenningNormann
Copy link
Contributor

@HenningNormann HenningNormann commented Apr 18, 2024 •
edited by SandGrainOne

Description

Set clockskew to 10 seconds when validating tokens to avoid problems if the caller's clock is slightly ahead of the validator's.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Set clockskew to 10 seconds when validating tokens to avoid problems …
f5a6936 
…if the caller's clock is slightly ahead of the validator's.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SandGrainOne SandGrainOne merged commit aac93b2 into main Apr 25, 2024
7 checks passed
@SandGrainOne SandGrainOne deleted the Feature/ClockSkew branch April 25, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne SandGrainOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HenningNormann @SandGrainOne