Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at the use of Microsoft.AspNet.WebApi.Client package from 2018 in some components (Events) #7601

Closed
8 tasks
SandGrainOne opened this issue Dec 6, 2021 · 3 comments
Labels
kind/user-story Used for issues that describes functionality for our users. quality/debt Shortcuts made for saving time. Fixing this will make us more efficient going forward. skip-releasenotes Issues that do not make sense to list in our release notes status/duplicate Status: An issue that is closed as a duplicate of another issue.

Comments

@SandGrainOne
Copy link
Member

SandGrainOne commented Dec 6, 2021

Description

The Microsoft.AspNet.WebApi.Client package is getting old. The last version of the package was released in 2018. It's used by at least one component and this is Events, but there might be more. We use it for it's extension methods on HttpContent to deserialize http responses, but there might be more.

The package has a dependency to Newtonsoft.

Up to date extension methods can be found in the System.Net.Http.Json namespace.

Specification tasks

  • Development tasks are defined

Development tasks

Test

Definition of done

  • Documentation (docs.altinn.studio) is updated (if relevant)
    • Technical documentation
    • User documentation
  • QA
  • Manual test is complete (if relevant)
  • Automated test is implemented (if relevant)
  • All tasks in this userstory are closed (i.e. remaining tasks are moved to other user stories or marked obsolete)
@SandGrainOne SandGrainOne added kind/user-story Used for issues that describes functionality for our users. QEB labels Dec 6, 2021
@altinnadmin
Copy link
Member

Is there a good reason for not using the extension methods in these classes instead?

https://docs.microsoft.com/en-us/dotnet/api/system.net.http.json

@altinnadmin altinnadmin added the quality/debt Shortcuts made for saving time. Fixing this will make us more efficient going forward. label Dec 7, 2021
@SandGrainOne
Copy link
Member Author

SandGrainOne commented Dec 7, 2021

Is there a good reason for not using the extension methods in these classes instead?
https://docs.microsoft.com/en-us/dotnet/api/system.net.http.json

I did mention that namespace in the desciption:

Up to date extension methods can be found in the System.Net.Http.Json namespace.

I just wasn't aware of it when I created this issue. (Despite having used it for the JsonContent class.)

@SandGrainOne
Copy link
Member Author

Moved the issue to the platform repository:
Altinn/altinn-events#246

@haakemon haakemon added status/duplicate Status: An issue that is closed as a duplicate of another issue. skip-releasenotes Issues that do not make sense to list in our release notes labels Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story Used for issues that describes functionality for our users. quality/debt Shortcuts made for saving time. Fixing this will make us more efficient going forward. skip-releasenotes Issues that do not make sense to list in our release notes status/duplicate Status: An issue that is closed as a duplicate of another issue.
Projects
None yet
Development

No branches or pull requests

3 participants