React query for form layouts #10140
Merged
React query for form layouts #10140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ui-editor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
TomasEng
force-pushed
the
react-query-form-layouts
branch
3 times, most recently
from
6a9665a
to
d7d824d
Compare
github-actions
bot
added
the
area/text-editor
TomasEng
force-pushed
the
react-query-form-layouts
branch
2 times, most recently
from
06a8d0d
to
13ebfbe
Compare
TomasEng
force-pushed
the
react-query-form-layouts
branch
from
13ebfbe
to
ceff8bc
Compare
framitdavid
reviewed
Apr 11, 2023
frontend/packages/ux-editor/src/features/formDesigner/activeList/activeListSagas.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/hooks/mutations/useDeleteAppAttachmentMetadataMutation.ts
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/hooks/mutations/useDeleteAppAttachmentMetadataMutation.ts
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor/src/hooks/mutations/useUpdateAppAttachmentMetadataMutation.ts
Dismissed
Show dismissed
Hide dismissed
frontend/packages/ux-editor/src/hooks/mutations/useUpdateAppAttachmentMetadataMutation.ts
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added React Query for form layouts, along with some improvements on typing and test coverage. In general, I have moved the logic from
formLayoutSagasto React Query mutation hooks. I have also added React Query Devtools, which is a very helpful component that is only visible in development mode.In addition, I have changed the logic that sets the "base container" ID. The old code set the ID to some random value, which led to bugs because this could happen multiple times and there was no intuitive way to find it in the list of containers. Therefore I have given it a constant value. Although this might be a better solution, it is still a quick fix, so we should consider finding a better way to handle this.
Related Issue(s)
Verification