Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language to IDataProcessor and as an optional query param to apis #405

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Jan 24, 2024

In data processing it is sometimes valuable to know the language the user currently is showing in the schema.

At least two cases comes to mind:

  1. Saving the language to the data model for knowing the language to use for potential follow up with the reportee
  2. Updating presentation values with correct language (Uke 2 2023 vs Week 2 2023).

This PR also adds a Roslyn rewrite to fix the interface.

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we could remove some replicated code though

src/Altinn.App.Api/Controllers/StatelessDataController.cs Outdated Show resolved Hide resolved
src/Altinn.App.Api/Controllers/StatelessDataController.cs Outdated Show resolved Hide resolved
@tjololo tjololo added the breaking-change Label Pull requests with breaking changes. Used when generating releasenotes label Jan 26, 2024
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
78.6% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Label Pull requests with breaking changes. Used when generating releasenotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants