Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Outline::Lua compile and work on Perl 5.12+ #2

Closed
wants to merge 2 commits into from

Conversation

maddingue
Copy link

The proposed changes allow Outline::Lua to compile on recent Perl, as well as making sure the module actually works on these versions.
Tested with 5.12.4, 5.14.2, 5.14.3, 5.16.2

@Altreus
Copy link
Owner

Altreus commented Mar 27, 2013

@maddingue Hey - I rebased your contribution onto my local branch so I could have a look at the diff.

Yours passes the tests and is much simpler than mine so I reckon that means it's better :)

I suspect you are more experienced in this than me; I would greatly appreciate some guidance of what in my own version I did not need to do, e.g. what of my version is just repeating myself, what I've misunderstood, etc. It seems like what I originally had has changed much less than I think it has.

Here's my version: https://github.com/Altreus/outline-lua/blob/80a5c5d/Lua.xs#L105

Anyway your version is current master, and since I rebased I'll close this :) And thanks!

11dd328

@Altreus Altreus closed this Mar 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants