Created dynamical detection system for vcredist. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution is independent of new versions.
Edited part of regular expression and changed Convert to TryParse for accuracy of parsing.
|
@CodeWheeR The previous maintainer of this package left the company, see #143. Also created a nuget package: https://www.nuget.org/packages/Yolo.Net/3.0.6-alpha.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This solution is independent of new versions. Version numbering of vcredist is usual: major.minor.build. So analysing of it is more reliable than name.
If you think that parsing name of registy key for version number is a bad idea, it is also can be taken from value Version of key. I just found it excess because this keys are created programmaticaly and values always matches. But this way we don't access the registry once again.
The working time of this ~1ms (~13k tics).