Fix wrong react-native dependency and wrong android package name #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* forcing a specific version of react native may result in incoherent react native versions, thus causing problems with native modules -> rather use a peer dependency with a version range * provide react as dependency as it is a peer dependency of react-native fixes #21
+ add the react methods addListener and removeListeners within android whose absence will trigger a warning within react native in newer releases (facebook/react-native@114be1d)
|
Looks good! Thank you for your merge request! |
|
🎉 This PR is included in version 1.2.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forcing a specific version of react native may result in incoherent react native versions, thus causing problems with native modules. This seems to be the fix of #21 as my debugging showed, that the EventEmitter listener did not get called. This may have been caused by the wrong version of react native forced by react-native-http-bridge-refurbished.
There were also errors within the android module, which I fixed alongside.
Please report back to me if this is also fixing #21 for you.