Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lee's subtitles don't match the audio (EN) #274

Open
Quintus24 opened this issue Dec 30, 2021 · 3 comments
Open

Lee's subtitles don't match the audio (EN) #274

Quintus24 opened this issue Dec 30, 2021 · 3 comments
Assignees
Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@Quintus24
Copy link

Quintus24 commented Dec 30, 2021

Hello, everyone!

I would like to report the following bug:

Describe the bug:
The issue can be encountered in the New Camp after completing the "Admission to the New Camp" quest.
If the user asks NPC "Lee" about joining the mercenaries, he can be heard saying, in EN: "I'll give you a chance. How about it?"
However, the subtitle is displayed in DE as: "Ich gebe dir eine Chance. Wie siehts aus?"

Expected behavior:
The subtitles of the conversation with Lee after completing the quest "Admission to the New Camp" now match the audio.

Steps to reproduce the issue:

  1. Initiate and complete the "Admission to the New Camp" quest.
  2. Travel to the NC_SMALL_CAVE_CENTER waypoint and talk with NPC "Lee".
  3. Select the "I'd like to become a mercenary of the mages - am I ready yet?" dialogue option.
  4. Notice the reply is spoken in EN and the subtitle is displayed in DE.

Additional context
My version of the game is in English.
The spoken dialogue is correct, no audio mismatch observed.

Attaching some screenshots for more clear information.

  1. Initiate conversation.
    Start Conversation

  2. EN subtitle.
    Dialogue 1 EN

  3. DE subtitle.
    Dialogue 2 DE

  4. Location at NC_SMALL_CAVE_CENTER waypoint.
    Location @ NC_SMALL_CAVE_CENTER

Thank You and Best Regards!
Quintus24

@Quintus24 Quintus24 added the validation: required This issue needs validation from one of the validators. label Dec 30, 2021
@szapp szapp added compatibility: difficult This issue is difficult to make compatible. impl: change obj var This issue requires changing properties of objects. type: revert on save The fix for this issue impacts the game and should be reverted when saving. labels Jan 8, 2022
@szapp szapp added this to Other in Fix templates Jan 8, 2022
@szapp
Copy link
Collaborator

szapp commented Jan 8, 2022

Relevant output unit:

AI_Output (self, other,"Sld_700_Lee_BECOMESLD_Info_08_04"); //Ich gebe dir eine Chance. Wie siehts aus?

@szapp szapp added the language dependent This issue only occurs in certain localizations. label Jan 8, 2022
@szapp szapp changed the title Subtitle localization mismatch for NPC "Lee". Lee's subtitles don't match the audio (EN) Jan 8, 2022
@szapp szapp moved this from Other to Dialog: Subtitles in Fix templates Jan 10, 2022
@szapp szapp added compatibility: easy This issue is easy to make compatible. type: session fix The fix for this issues is persistent across a session. and removed type: revert on save The fix for this issue impacts the game and should be reverted when saving. compatibility: difficult This issue is difficult to make compatible. labels Jan 16, 2022
@AmProsius
Copy link
Owner

See #278.

@AmProsius AmProsius self-assigned this Jan 18, 2022
@AmProsius AmProsius added this to To Do in v1.3.0 via automation Jan 18, 2022
@AmProsius AmProsius added this to the v1.3.0 milestone Jan 18, 2022
@szapp
Copy link
Collaborator

szapp commented Jan 18, 2022

Just as a few notes, since #278 is a bit special as it is an SVM and not a dialog. For dialogs it will be like this.

  1. The name of the OU is found in the AI_Output command. Here, e.g. it is Sld_700_Lee_BECOMESLD_Info_08_04.
  2. A suitable function name for the fix may be G1CP_274_EN_LeeAdmissionOu. This way it is consistent with fix names like G1CP_031_WolfPlateDialog, i.e. [NPCname] [Context] [Modality].
  3. Content-wise the fix should be the same for both SVM OU or dialog OU.

@AmProsius AmProsius added validation: validated This issue is still present even with Systempack/Union. and removed validation: required This issue needs validation from one of the validators. labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change dialog subtitles
v1.3.0
  
To Do
Development

No branches or pull requests

3 participants