Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling - "Quotation Marks" in NPC "Lester" subtitle. #382

Open
Quintus24 opened this issue Apr 2, 2023 · 1 comment
Open

Spelling - "Quotation Marks" in NPC "Lester" subtitle. #382

Quintus24 opened this issue Apr 2, 2023 · 1 comment
Assignees
Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Milestone

Comments

@Quintus24
Copy link

Hello, everyone!

I would like to report the following bug:

Describe the bug:
This issue can be encountered in the Swamp Camp when talking with NPC "Lester" and inquiring about the smithy.
Upon reaching the destination, NPC "Lester" will reply and the following subtitle string is displayed: "That's the smithy! Have a look around: I'll wait here for about an hour, then I'll leave."
The quotation marks displayed at the beginning/ending of the string are not necessary.

Expected behavior:
The subtitle string is correctly displayed as: That's the smithy! Have a look around: I'll wait here for about an hour, then I'll leave.

Steps to reproduce the issue:

  1. Travel to the Swamp Camp and reach the PSI_GUARD_TREE_EX waypoint.
  2. Talk with NPC "Lester" and select the "Show me the way ..." option.
  3. Select the "to the smithy" option and follow Lester.
  4. Reach the PSI_SMITH_IN waypoint and trigger Lester's dialogue.
  5. Notice the "quotation marks" issue in Lester's subtitle string.

Additional context
N/A

Attaching screenshots for more clear information.

  1. NPC "Lester" at PSI_GUARD_TREE_EX waypoint.
    Lester @ PSI_GUARD_TREE_EX Waypoint

  2. Initiate Dialogue 1.
    Initiate Dialogue 1

  3. Initiate Dialogue 2.
    Initiate Dialogue 2

  4. Quotation Marks Issue.
    Quotation Marks

Thank You and Best Regards!
Quintus24

@Quintus24 Quintus24 added the validation: required This issue needs validation from one of the validators. label Apr 2, 2023
@AmProsius AmProsius added validation: validated This issue is still present even with Systempack/Union. and removed validation: required This issue needs validation from one of the validators. labels Feb 19, 2024
@AmProsius
Copy link
Owner

AmProsius commented Feb 19, 2024

Similar to #274.

Relevant output unit:

AI_Output (self, other,"PC_Psionic_SMITH_Info_05_01"); //"That's the smithy! Have a look around; I'll wait here for about an hour, then I'll leave."

@AmProsius AmProsius added language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. labels Feb 19, 2024
@AmProsius AmProsius added this to To Do in v1.3.0 via automation Feb 19, 2024
@AmProsius AmProsius added this to the v1.3.0 milestone Feb 19, 2024
@AmProsius AmProsius added this to Change dialog subtitles in Fix templates Feb 19, 2024
@AmProsius AmProsius self-assigned this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy This issue is easy to make compatible. impl: change obj var This issue requires changing properties of objects. language dependent This issue only occurs in certain localizations. type: session fix The fix for this issues is persistent across a session. validation: validated This issue is still present even with Systempack/Union.
Projects
Fix templates
Change dialog subtitles
v1.3.0
  
To Do
Development

No branches or pull requests

2 participants