Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#49: Fix the item text of the dungeon key #106

Merged
merged 1 commit into from Feb 9, 2021
Merged

#49: Fix the item text of the dungeon key #106

merged 1 commit into from Feb 9, 2021

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Feb 9, 2021

Description

Fixes #49. Interestingly, I found a way to fix this issue completely language independent. The exact wording does not matter: if the second line of text overwrites the first line, it will be corrected.

Test

Run automatic test with test 49.

The test, however, only supports English and German localization. Both should be tested (I only tested English). Three additional tests are yet to be performed.

  1. Test in German localization (especially important because of the umlaut 'ö' in the key text)
  2. Do an additional manual test where the key was in the world before the fix was applied, i.e. create a game save with the key inserted, then apply the fix, load the game and manually confirm that the key's text was updated.
  3. Do a test on a mod that already fixed the issue.

The fix is language independent, but the test is (EN/DE)
@AmProsius
Copy link
Owner

All tests passed:

  1. The key has the correct description in the German version of the game.
  2. After loading a savegame with the key already inserted, the description was correct.
  3. The description also was correct when tested with the UnPatch mod.

ScreenShot_2021_2_9_19_54_17

@AmProsius AmProsius merged commit 585a33f into master Feb 9, 2021
@AmProsius AmProsius deleted the bug049 branch February 9, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dungeon Key description faulty
2 participants