Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#163: Unblock the castle gate #164

Merged
merged 5 commits into from Mar 3, 2021
Merged

#163: Unblock the castle gate #164

merged 5 commits into from Mar 3, 2021

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Feb 27, 2021

Description

Fixes #163. Unblock the castle gate of the Old Camp to let it properly close.

Test

Run manual test with test 163.

Additional Information

  • Currently the winch is moved to the opposite wall to remove its collision with the gate. There is an alternative mentioned in Castle gate of the Old Camp cannot close #163.
  • If the gate is closed, its state is written to the game save. So far it is not handled yet to revert the gate's state before saving.

The points above should be discussed/adjusted before merging this PR. Therefore it is marked as draft for the time being.

@szapp
Copy link
Collaborator Author

szapp commented Feb 28, 2021

The fix is now converted to a session fix and is ready for review/testing/merging.

@szapp szapp marked this pull request as ready for review February 28, 2021 16:01
@AmProsius AmProsius merged commit 5a174b2 into master Mar 3, 2021
@AmProsius AmProsius deleted the bug163 branch March 3, 2021 21:52
@szapp szapp mentioned this pull request Jan 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Castle gate of the Old Camp cannot close
2 participants
@szapp @AmProsius