Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#46: Fix the key instance of the smithy's door #167

Merged
merged 5 commits into from Mar 5, 2021
Merged

#46: Fix the key instance of the smithy's door #167

merged 5 commits into from Mar 5, 2021

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Feb 28, 2021

Description

Fixes #46. Make the smithy's door accessible.

Test

Run manual test with test 46. The test has two passes.

  1. First function call: The PC is teleported to Stone's cell and the story is advanced to chapter 4.
  2. Second function call: The PC is teleported in front of the door.

There are some tests to check off.

  • The key shows up in Stone's cell (first pass)
  • The key opens the door (second pass)
  • The key is still present in the inventory after saving, quitting the game, restarting and loading
  • The key is still present in the world (drop it on the ground) after saving, quitting the game, restarting and loading
  • The key is still present in a chest after saving, quitting the game, restarting and loading
  • The key is gone when removing G1CP and loading (there should be no visible error) most interesting one
  • The key is properly re-inserted when re-installing G1CP (note that this only works for game saves where the door was not unlocked yet).

To understand when the key is and is not inserted, the flow-chart may be consulted (or even verified).

@szapp
Copy link
Collaborator Author

szapp commented Mar 1, 2021

I think there is still a problem. When loading a game save twice the door might not be locked again. I will have a look before merging.

@szapp szapp marked this pull request as draft March 1, 2021 07:43
@szapp
Copy link
Collaborator Author

szapp commented Mar 1, 2021

I removed re-locking of the door. The reasoning:

When reverting, the door will not be locked again. The reasoning behind this is, that G1CP is only supplying a way of unlocking the door. It's the player that may unlock it. G1CP will only revert its own actions, not the consequences.

I hope we can agree on this.

@szapp szapp marked this pull request as ready for review March 1, 2021 18:28
@AmProsius
Copy link
Owner

AmProsius commented Mar 1, 2021

Do I understand correctly that the key won't fit anymore, but the door remains open, because the player unlocked it before (if he did so)? If so, I don't see any problem as the saves won't be affected.

@szapp szapp mentioned this pull request Mar 3, 2021
@szapp szapp marked this pull request as draft March 3, 2021 21:18
@szapp szapp requested a review from AmProsius March 4, 2021 21:42
@szapp szapp marked this pull request as ready for review March 4, 2021 21:42
@AmProsius AmProsius merged commit 2b5e599 into master Mar 5, 2021
@AmProsius AmProsius deleted the bug046 branch March 5, 2021 19:48
@szapp szapp restored the bug046 branch February 6, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Door near the smithy in the castle of the Old Camp is inaccessible
2 participants