Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: lint errors on new Otter applications and libraries #1690

Closed
vscaiceanu-1a opened this issue Apr 19, 2024 · 0 comments · Fixed by #1698
Closed

[Bug]: lint errors on new Otter applications and libraries #1690

vscaiceanu-1a opened this issue Apr 19, 2024 · 0 comments · Fixed by #1698
Labels
bug Something isn't working

Comments

@vscaiceanu-1a
Copy link
Member

Package name

create, eslint-config-otter

Package version

10.1.7

Reproduction steps

Assume #1661 is fixed.

npm create @o3r otter-project
cd otter-project
ng add @o3r/eslint-config-otter
ng g application webapp
# choose preset BASIC, no Jest and no Playwright when prompted
ng g library mylib
npm run ng lint

Current result

for the app:

✖ 9 problems (9 errors, 0 warnings)
  5 errors and 0 warnings potentially fixable with the `--fix` option.

Lint errors found in the listed files.

for the lib:

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

Lint errors found in the listed files.

Expected result

All files pass linting.

Additional comments

We also have to write IT tests to make sure there are no lint errors for apps and libs.

@vscaiceanu-1a vscaiceanu-1a added the bug Something isn't working label Apr 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 26, 2024
## Proposed change

## Related issues

- 🐛 Fixes #1676
- 🐛 Fixes #1690

<!-- Please make sure to follow the contributing guidelines on
https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant