feat(ama-sdk-create): allow creation without a scope #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
force-pushed
the
scopelessAmaSdkCreate
branch
from
7f0d8b4
to
7d65982
Compare
matthieu-crouzet
previously approved these changes
Mar 12, 2024
|
@matthieu-crouzet Thank you for your review! |
kpanot
reviewed
Mar 13, 2024
divdavem
force-pushed
the
scopelessAmaSdkCreate
branch
from
7d65982
to
7231388
Compare
kpanot
approved these changes
Mar 13, 2024
fpaul-1A
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When running
npm create @ama-sdk typescript my-package, I would intuitively expect amy-packagepackage to be created inmy-packagefolder.What currently happens is the creation of the
@sdk/my-packagepackage inside thesdk/my-packagefolder. Why is thissdkscope added? I suggest in this PR to remove thesdkdefault scope.