Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split and export renovate presets #1516

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Mar 19, 2024

Proposed change

Split and export renovate presets

Related issues

@kpanot kpanot requested a review from a team as a code owner March 19, 2024 06:47
Copy link

nx-cloud bot commented Mar 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d298010. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

docs/renovate/readme.md Outdated Show resolved Hide resolved
docs/renovate/readme.md Outdated Show resolved Hide resolved
docs/renovate/readme.md Outdated Show resolved Hide resolved
@kpanot kpanot force-pushed the feature/renovate-configurations branch from 8708bd8 to 6709f94 Compare March 20, 2024 06:06
fpaul-1A
fpaul-1A previously approved these changes Mar 20, 2024
],
"prConcurrentLimit": 0,
"prHourlyLimit": 0,
"baseBranches": [
"master"
"main"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change from master to main like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be align with github and bitbucket default base branch name.

"yarn run ng update {{{depName}}} --from={{{currentVersion}}} --to={{{newVersion}}} --migrate-only --allow-dirty --force"
],
"fileFilters": [
"!**/.npmrc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to patch the yarnrc to run the install and subsequent script, the yarnrc should also be excluded from the files to commit

Suggested change
"!**/.npmrc"
"!**/.{npmrc,yarnrc*}"

],
"executionMode": "branch",
"fileFilters": [
"!**/.npmrc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark to add the yarnrc file

"npm run swagger:generate"
],
"fileFilters": [
"!**/.npmrc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark for yarnrc

"yarn run swagger:generate"
],
"fileFilters": [
"!**/.npmrc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark for yarnrc

@kpanot kpanot added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit 18c4f43 Mar 22, 2024
22 checks passed
@kpanot kpanot deleted the feature/renovate-configurations branch March 22, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Provide Renovate Presets for Otter recommended rules
3 participants