Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chrome-ext): styling panel #1581

Merged
merged 1 commit into from
Apr 4, 2024
Merged

feat(chrome-ext): styling panel #1581

merged 1 commit into from
Apr 4, 2024

Conversation

matthieu-crouzet
Copy link
Contributor

@matthieu-crouzet matthieu-crouzet commented Apr 2, 2024 •
edited

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner April 2, 2024 15:09
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 2, 2024 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 790fdc7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@matthieu-crouzet matthieu-crouzet linked an issue Apr 2, 2024 that may be closed by this pull request
[Feature]: Add the possibility to override styling variable in chrome extension #1494
Open
4 tasks
@matthieu-crouzet matthieu-crouzet force-pushed the feat/chrome-styling branch 2 times, most recently from b4af8cc to 686c6e7 Compare April 2, 2024 15:57
kpanot
kpanot reviewed Apr 3, 2024
View reviewed changes
packages/@o3r/styling/src/devkit/styling-devkit.interface.ts Outdated Show resolved Hide resolved
apps/chrome-devtools/src/app-devtools/theming-panel/common.ts Outdated Show resolved Hide resolved
apps/chrome-devtools/src/app-devtools/theming-panel/common.ts Outdated Show resolved Hide resolved
apps/chrome-devtools/src/app-devtools/theming-panel/common.ts Show resolved Hide resolved
apps/chrome-devtools/src/app-devtools/theming-panel/common.ts Outdated Show resolved Hide resolved
apps/showcase/src/style/design-token.figma.json Outdated Show resolved Hide resolved
packages/@o3r/styling/src/devkit/styling-devtools.service.ts Outdated Show resolved Hide resolved
packages/@o3r/styling/src/devkit/styling-devtools.service.ts Outdated Show resolved Hide resolved
packages/@o3r/styling/src/devkit/styling-devtools.token.ts Show resolved Hide resolved
packages/@o3r/styling/src/devkit/styling-devtools.module.ts Show resolved Hide resolved
@matthieu-crouzet matthieu-crouzet force-pushed the feat/chrome-styling branch 2 times, most recently from 09de3a8 to 1ee9533 Compare April 3, 2024 13:11
@matthieu-crouzet matthieu-crouzet removed a link to an issue Apr 3, 2024
[Feature]: Add the possibility to override styling variable in chrome extension #1494
Open
4 tasks
fpaul-1A
fpaul-1A previously approved these changes Apr 3, 2024
View reviewed changes
@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 1f18b01 Apr 4, 2024
22 checks passed
@matthieu-crouzet matthieu-crouzet deleted the feat/chrome-styling branch April 4, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdo-1A sdo-1A sdo-1A left review comments

@kpanot kpanot kpanot approved these changes

@fpaul-1A fpaul-1A fpaul-1A approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request project:@o3r/chrome-devtools project:@o3r/showcase project:@o3r/storybook project:@o3r/styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthieu-crouzet @kpanot @fpaul-1A @sdo-1A