Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSRV to Cargo.toml #348

Merged
merged 1 commit into from Oct 17, 2023
Merged

Add MSRV to Cargo.toml #348

merged 1 commit into from Oct 17, 2023

Conversation

claui
Copy link
Contributor

@claui claui commented Aug 18, 2022

Add a rust_version entry to Cargo.toml in order to codify the MSRV for cargo to pick it up.
This leads to a more helpful and more actionable error message, for example:

error: package parking_lot v0.12.1 ([…]) cannot be built because
it requires rustc 1.59 or newer, while the currently active rustc
version is 1.58.1

Supersedes #347.

Add a `rust_version` entry to `Cargo.toml` in order to codify the MSRV
for `cargo` to pick it up. This leads to a more helpful and more
actionable error message, for example:

> error: package `parking_lot v0.12.1 ([…])` cannot be built because
> it requires rustc 1.59 or newer, while the currently active rustc
> version is 1.58.1
@claui claui mentioned this pull request Aug 18, 2022
@Amanieu Amanieu merged commit 8e9b3b9 into Amanieu:master Oct 17, 2023
@claui claui deleted the rust-version branch October 18, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants