Eduu code reorganized for package format #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iiiiii1wepfj
suggested changes
May 19, 2021
But why no? |
|
@AndrielFR but why yes? |
|
Overall it looks good, but for eduu.database I would move it into a database.py file, since there is just one file. |
I left it in a folder because it creates the |
alissonlauffer
approved these changes
May 20, 2021
since it is more meaningful
|
This pull request introduces 2 alerts when merging f0f75df into 6237387 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging c65c5be into 6237387 - view on LGTM.com new alerts:
|
…username` _this will fix the `PYL-W0212` issue from DeepSource_
_Based on Codacy and DeepSource analysis_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this reorganization using Black and Isort and at Alisson's request, I did not test exactly everything but it seems to me to be all working
, all GitHub workflows will fail because the location of the.version.txthas been changed then Alisson should change the workflow configuration file