Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: numerous improvements and added aiosqlite #322

Merged
merged 5 commits into from Apr 25, 2022
Merged

treewide: numerous improvements and added aiosqlite #322

merged 5 commits into from Apr 25, 2022

Conversation

HitaloM
Copy link
Member

@HitaloM HitaloM commented Apr 23, 2022

General improvements

I've made some general improvements, but it takes deeper testing, I've tested everything and apparently it works as it should.

  • Using the aiosqlite library for the database
  • Using custom pyrogram client for better organization
  • Added logs

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2022

This pull request introduces 1 alert when merging 83a822d into d6cc484 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2022

This pull request introduces 1 alert when merging 2274874 into d6cc484 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@HitaloM HitaloM changed the title Added aiosqlite treewide: numerous improvements and added aiosqlite Apr 23, 2022
Copy link
Member

@alissonlauffer alissonlauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update config.py.example to reflect new changes added to config? I will update config.py too then.

But overall LGTM.

@AndrielFR
Copy link
Member

Can you update config.py.example to reflect new changes added to config? I will update config.py too then.

But overall LGTM.

i was going to say that

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2022

This pull request introduces 1 alert when merging fb6a578 into 0a88eab - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

Copy link
Member

@alissonlauffer alissonlauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2022

This pull request introduces 1 alert when merging 699e9f4 into ae0517b - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

@alissonlauffer alissonlauffer merged commit 745d404 into AmanoTeam:main Apr 25, 2022
alissonlauffer added a commit that referenced this pull request Apr 25, 2022
Co-authored-by: Alisson Lauffer <alissonvitortc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants