Add an HTML crawler and translator #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… text in HTML tags or attributes via XPath expressions
rossmotley
reviewed
Mar 13, 2017
src/Amara/Varcon/HtmlCrawler.php
Outdated
| { | ||
| $document = new DOMDocument(); | ||
| $document->loadHTML(mb_convert_encoding( | ||
| sprintf('<div>%s</div>', $content), |
There was a problem hiding this comment.
Perhaps add a comment explaining why we add a div here?
| */ | ||
| interface TranslatorInterface | ||
| { | ||
| const QUESTIONABLE_IGNORE = 0; |
There was a problem hiding this comment.
Perhaps add a description for what these constants do?
| Argument::any(), | ||
| Argument::any(), | ||
| Argument::any() | ||
| )->willReturn('Translated'); // Keep in mind we ignore whitespace this way |
There was a problem hiding this comment.
It might make this test better to have it return the text passed in appended with 'Translated' rather than always 'Translated'
rossmotley
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables translation of HTML tags or attributes via XPath expressions.