Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to read a JSON config file #21

Merged
merged 1 commit into from Oct 12, 2021

Conversation

JerryHue
Copy link
Contributor

@JerryHue JerryHue commented Oct 9, 2021

This addresses issue #20.

I had to modify main.js, specifically the function writeHTML, because it would throw an error every time I tried to pass a single file to the program.

@AmasiaNalbandian
Copy link
Owner

Hi Jerry! Thanks for the contribution - to clarify does the config file support multiple inputs/languages like the cli does?

@JerryHue
Copy link
Contributor Author

Indeed it does! You would have to write an array of strings, each string being the language you want to support.

@AmasiaNalbandian
Copy link
Owner

I love it! Thanks so much for the contribution. I was worried about the multiple inputs but it's working great! :)

@AmasiaNalbandian AmasiaNalbandian merged commit de02468 into AmasiaNalbandian:main Oct 12, 2021
@AmasiaNalbandian AmasiaNalbandian linked an issue Oct 16, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept a configuration file through --config
2 participants