You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remember process remember checks for prior remembering, as it is used by the
final callback on both listen and respond, as respond might be called without a
listen.
There could be a more graceful way of handling the thought process completion,
like possible using a single interface for all processes. e.g. thought('hear', args)
Then it can add the final piece only once, when used either as thought('hear')
or thought('respond'). Could still retain bot.hear and bot.respond as proxies.
Should that also revert usage of bot.listen in place of bot.listenText.
Maybe all thought stages should only be called internally and bot accessors are bot.receive and bot.send - for hubot compatibility and since when bot.respond is called directly, its actually unprompted, therefore not a
response.
Consider renaming thought-process.ts as just thought.ts too.
Move adapter storage check into brain, remember should just call keep.
Consider use of thought for custom contained sets of listeners (e.g. within a
scene), might make sense to accept the listeners as arg, but use the 'global'
listeners as default. Scenes shouldn't reproduce thought process the way it is
in current Playbook.
- fixes#65, #68, #69
- thought processes now accessed by instance of Thought
- sets of listeners now instance of Listeners
- instances of thought can run on isolted set of listeners
- listener helpers add to global listener set
- adapter base classes use method abstracts
- envelope added as module, moved from message
- envelope helpers added, moved from state
- updated thought process and hubot migration doc
- fixes#65, #68, #69
- thought processes now accessed by instance of Thought
- sets of listeners now instance of Listeners
- instances of thought can run on isolted set of listeners
- listener helpers add to global listener set
- adapter base classes use method abstracts
- envelope added as module, moved from message
- envelope helpers added, moved from state
- updated thought process and hubot migration doc
Remember process
remember
checks for prior remembering, as it is used by thefinal callback on both listen and respond, as respond might be called without a
listen.
There could be a more graceful way of handling the thought process completion,
like possible using a single interface for all processes. e.g.
thought('hear', args)
Then it can add the final piece only once, when used either as thought('hear')
or thought('respond'). Could still retain bot.hear and bot.respond as proxies.
Should that also revert usage of
bot.listen
in place ofbot.listenText
.Maybe all thought stages should only be called internally and bot accessors are
bot.receive
andbot.send
- for hubot compatibility and since whenbot.respond
is called directly, its actually unprompted, therefore not aresponse.
Consider renaming
thought-process.ts
as justthought.ts
too.Move adapter storage check into brain, remember should just call keep.
Consider use of thought for custom contained sets of listeners (e.g. within a
scene), might make sense to accept the listeners as arg, but use the 'global'
listeners as default. Scenes shouldn't reproduce thought process the way it is
in current Playbook.
see https://github.com/Amazebot/bbot/blob/master/src/lib/thought-process.ts#L94
The text was updated successfully, but these errors were encountered: