Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thought process updates for alpha #68

Closed
timkinnane opened this issue Jun 25, 2018 · 0 comments
Closed

Thought process updates for alpha #68

timkinnane opened this issue Jun 25, 2018 · 0 comments
Labels
ENHANCE Improve something
Projects
Milestone

Comments

@timkinnane
Copy link
Contributor

Remember process remember checks for prior remembering, as it is used by the
final callback on both listen and respond, as respond might be called without a
listen.

There could be a more graceful way of handling the thought process completion,
like possible using a single interface for all processes. e.g.
thought('hear', args)

Then it can add the final piece only once, when used either as thought('hear')
or thought('respond'). Could still retain bot.hear and bot.respond as proxies.

Should that also revert usage of bot.listen in place of bot.listenText.
Maybe all thought stages should only be called internally and bot accessors are
bot.receive and bot.send - for hubot compatibility and since when
bot.respond is called directly, its actually unprompted, therefore not a
response.

Consider renaming thought-process.ts as just thought.ts too.
Move adapter storage check into brain, remember should just call keep.

Consider use of thought for custom contained sets of listeners (e.g. within a
scene), might make sense to accept the listeners as arg, but use the 'global'
listeners as default. Scenes shouldn't reproduce thought process the way it is
in current Playbook.

see https://github.com/Amazebot/bbot/blob/master/src/lib/thought-process.ts#L94

@timkinnane timkinnane added the ENHANCE Improve something label Jun 25, 2018
@timkinnane timkinnane added this to the Alpha milestone Jun 25, 2018
@timkinnane timkinnane added this to To do in Roadmap via automation Jun 25, 2018
@timkinnane timkinnane moved this from To do to Next up in Roadmap Jun 25, 2018
@timkinnane timkinnane moved this from Next up to In progress in Roadmap Jun 26, 2018
timkinnane added a commit that referenced this issue Jun 29, 2018
- fixes #65, #68, #69
- thought processes now accessed by instance of Thought
- sets of listeners now instance of Listeners
- instances of thought can run on isolted set of listeners
- listener helpers add to global listener set
- adapter base classes use method abstracts
- envelope added as module, moved from message
- envelope helpers added, moved from state
- updated thought process and hubot migration doc
Roadmap automation moved this from In progress to Done Jun 29, 2018
timkinnane added a commit that referenced this issue Aug 12, 2018
- fixes #65, #68, #69
- thought processes now accessed by instance of Thought
- sets of listeners now instance of Listeners
- instances of thought can run on isolted set of listeners
- listener helpers add to global listener set
- adapter base classes use method abstracts
- envelope added as module, moved from message
- envelope helpers added, moved from state
- updated thought process and hubot migration doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Improve something
Projects
Roadmap
  
Done
Development

No branches or pull requests

1 participant