Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor memory const as class, with helpers #96

Closed
timkinnane opened this issue Aug 13, 2018 · 0 comments
Closed

Refactor memory const as class, with helpers #96

timkinnane opened this issue Aug 13, 2018 · 0 comments
Labels
ENHANCE Improve something

Comments

@timkinnane
Copy link
Contributor

Memory functions exposed at the root bot level are too generic, like get, set, unset. They should be methods of memory and operate on the memory instance self.

That would also allow get to be repurposed for getRequest so get and post can be request shortcuts instead.
@timkinnane timkinnane added the ENHANCE Improve something label Aug 13, 2018
timkinnane added a commit that referenced this issue Aug 23, 2018
@timkinnane
feat(request): Add timeout setting for requests
404b87c 
Also moved requests to class instance, for consistent namespacing with other modules.

BREAKING CHANGE: Request methods now accessed from request instance instead of bot, like
`bot.request.get` instead of `bot.getRequest`

re #96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ENHANCE Improve something
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timkinnane