-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg entity usage improvements #1389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on silverback-template
. Works great! But only for nodes.
For media we need to investigate more. This is what I saw in the database when tried to link a node and a media:
<!-- wp:paragraph -->
<p>a link to <a href="/node/6c0ac38d-ab7d-452d-b4d2-a98814fde715" data-type="Content: Basic page" data-id="6c0ac38d-ab7d-452d-b4d2-a98814fde715" data-entity-type="node">page</a></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p>a link to <a href="/media/5" data-type="Media: Document" data-id="0d00d8a2-65eb-4496-8e36-294e18b044ec">media</a></p>
<!-- /wp:paragraph -->
For media:
href
is not transformed to uuid - can cause issues with content exportdata-entity-type
is missing - probably that's why it's not tracked
Could you take a look at the media? Maybe it's easy to fix. Or let's merge this one and create follow-ups for media.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chindris I won't test it manually this time. The changes look good! Let's merge and enable it in the template?
Hi @Leksat ! |
Package(s) involved
silverback_gutenberg
Description of changes
Adds two entity usage plugins:
Related Issue(s)
#1382
How has this been tested?