Fix Fairy Ascension as bunny

A longstanding issue is that Fairy Ascension Cave has been treated as a simple two way connector, but in reality bunny cannot "logically" go through the cave in reverse as it requires lifting some pots with super bunny. This super bunny state is effectively unavoidable and can really only be lost if you have Boots and foolishly bonk before lifting a pot, but for logical consistency fixing this is the right thing to do. The logic should now correctly see that the cave is a two way connection with no particular item requirements in general but that the reverse direction isn't bunny transversable.

EntranceShuffle.py

@@ -1828,6 +1828,9 @@ def tuplize_lists_in_list(ls):
                          ('Fairy Ascension Drop', 'East Death Mountain (Bottom)'),
                          ('Fairy Ascension Ledge Drop', 'Fairy Ascension Plateau'),
                          ('Fairy Ascension Ledge', 'Fairy Ascension Ledge'),
+                         ('Fairy Ascension Cave Climb', 'Fairy Ascension Cave (Top)'),
+                         ('Fairy Ascension Cave Pots', 'Fairy Ascension Cave (Bottom)'),
+                         ('Fairy Ascension Cave Drop', 'Fairy Ascension Cave (Drop)'),
                          ('Spectacle Rock Mirror Spot', 'Spectacle Rock'),
                          ('Dark Death Mountain Drop (East)', 'Dark Death Mountain (East Bottom)'),
                          ('Dark Death Mountain Drop (West)', 'Dark Death Mountain (West Bottom)'),
@@ -2002,8 +2005,8 @@ def tuplize_lists_in_list(ls):
                        ('Paradox Cave Exit (Middle)', 'East Death Mountain (Bottom)'),
                        ('Paradox Cave Exit (Top)', 'East Death Mountain (Top)'),
                        ('Hookshot Fairy', 'Hookshot Fairy'),
-                       ('Fairy Ascension Cave (Bottom)', 'Fairy Ascension Cave'),
-                       ('Fairy Ascension Cave (Top)', 'Fairy Ascension Cave'),
+                       ('Fairy Ascension Cave (Bottom)', 'Fairy Ascension Cave (Bottom)'),
+                       ('Fairy Ascension Cave (Top)', 'Fairy Ascension Cave (Top)'),
                        ('Fairy Ascension Cave Exit (Bottom)', 'Fairy Ascension Plateau'),
                        ('Fairy Ascension Cave Exit (Top)', 'Fairy Ascension Ledge'),
                        ('Spiral Cave', 'Spiral Cave (Top)'),

Regions.py

@@ -141,7 +141,9 @@ def create_regions(world):
         create_cave_region('Spiral Cave (Top)', 'a connector', ['Spiral Cave'], ['Spiral Cave (top to bottom)', 'Spiral Cave Exit (Top)']),
         create_cave_region('Spiral Cave (Bottom)', 'a connector', None, ['Spiral Cave Exit']),
         create_lw_region('Fairy Ascension Plateau', None, ['Fairy Ascension Drop', 'Fairy Ascension Cave (Bottom)']),
-        create_cave_region('Fairy Ascension Cave', 'a connector', None, ['Fairy Ascension Cave Exit (Top)', 'Fairy Ascension Cave Exit (Bottom)']),
+        create_cave_region('Fairy Ascension Cave (Bottom)', 'a connector', None, ['Fairy Ascension Cave Climb', 'Fairy Ascension Cave Exit (Bottom)']),
+        create_cave_region('Fairy Ascension Cave (Drop)', 'a connector', None, ['Fairy Ascension Cave Pots']),
+        create_cave_region('Fairy Ascension Cave (Top)', 'a connector', None, ['Fairy Ascension Cave Exit (Top)', 'Fairy Ascension Cave Drop']),
         create_lw_region('Fairy Ascension Ledge', None, ['Fairy Ascension Ledge Drop', 'Fairy Ascension Cave (Top)']),
         create_lw_region('Death Mountain (Top)', ['Ether Tablet'], ['East Death Mountain (Top)', 'Tower of Hera', 'Death Mountain Drop']),
         create_lw_region('Spectacle Rock', ['Spectacle Rock'], ['Spectacle Rock Drop']),

Rules.py

@@ -840,7 +840,7 @@ def set_bunny_rules(world):
     # regions for the exits of multi-entrace caves/drops that bunny cannot pass
     # Note spiral cave may be technically passible, but it would be too absurd to require since OHKO mode is a thing.
     bunny_impassable_caves = ['Bumper Cave', 'Two Brothers House', 'Hookshot Cave', 'Skull Woods First Section (Right)', 'Skull Woods First Section (Left)', 'Skull Woods First Section (Top)', 'Turtle Rock (Entrance)', 'Turtle Rock (Second Section)', 'Turtle Rock (Big Chest)', 'Skull Woods Second Section (Drop)',
-                              'Turtle Rock (Eye Bridge)', 'Sewers', 'Pyramid', 'Spiral Cave (Top)', 'Desert Palace Main (Inner)']
+                              'Turtle Rock (Eye Bridge)', 'Sewers', 'Pyramid', 'Spiral Cave (Top)', 'Desert Palace Main (Inner)', 'Fairy Ascension Cave (Drop)']
 
     bunny_accessible_locations = ['Link\'s Uncle', 'Sahasrahla', 'Sick Kid', 'Lost Woods Hideout', 'Lumberjack Tree', 'Checkerboard Cave', 'Potion Shop', 'Spectacle Rock Cave', 'Pyramid', 'Hype Cave - Generous Guy', 'Peg Cave', 'Bumper Cave Ledge', 'Dark Blacksmith Ruins']