Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMPRESSION event: adSlot argument #177

Closed
Ivshti opened this issue Jun 3, 2019 · 0 comments
Closed

IMPRESSION event: adSlot argument #177

Ivshti opened this issue Jun 3, 2019 · 0 comments
Assignees
@samparsky
Milestone
v0.6

Comments

@Ivshti
Copy link
Member

Ivshti commented Jun 3, 2019

The IMPRESSION event should take an optional adUnit property which, when passed, we have to use ${publisherAddr}:${adUnit} rather than publisherAddr as a key in eventCounts, making each unit count separately

should be implemented in mergeImpressionEv in eventReducer
@Ivshti Ivshti modified the milestones: v0.5, v0.6 Jun 3, 2019
@samparsky samparsky mentioned this issue Jun 13, 2019
Merged
@Ivshti Ivshti closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samparsky samparsky

Labels
None yet
Projects
None yet
Milestone
v0.6
Development

No branches or pull requests
2 participants
@Ivshti @samparsky