Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: eventSubmission #131

Merged
merged 14 commits into from
Apr 19, 2019
Merged

enhancement: eventSubmission #131

merged 14 commits into from
Apr 19, 2019

Conversation

Ivshti
Copy link
Member

@Ivshti Ivshti commented Apr 19, 2019

this branch implements eventSubmission and IP rate limits as defined by https://github.com/AdExNetwork/adex-protocol/blob/master/campaignSpec.md#eventsubmission

it also refactors access management of the sentry to lib/access

fixes #21

Why we're implementing it here, rather than as an NGINX config: (1) the sentry needs to be self sufficient and (2) the sentry will be re-implemented with rust/tokio so it will have better performance than NGINX

Copy link
Member

@ivopaunov ivopaunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe few more tests for submitting multiple events from channel.creator

@Ivshti
Copy link
Member Author

Ivshti commented Apr 19, 2019

Maybe few more tests for submitting multiple events from channel.creator

@ivopaunov
i didn't do this cause most of the other tests do submit events all the time, from the creator
if that didn't work then all those tests would fail (and I tested that :D)

@Ivshti Ivshti requested a review from ivopaunov April 19, 2019 13:16
@Ivshti Ivshti merged commit 73bd8af into master Apr 19, 2019
@Ivshti Ivshti deleted the enhancement/eventsubmission branch July 5, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement limits per user, sybil protection (IP, address, PoW, etc.) at a sentry level
2 participants