New health #175
Merged
New health #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous health function was independent of the channel deposit. This meant that, when channels have a few events (impressions), discrepancies can easily happen; e.g. 2 impressions for the follower but 1 by the leader will cause an unhealthy status
This new updated function calculates a
acceptableDifference, which ischannel.deposit * (1-HEALTH_THRESHOLD); for example, a threshold of 950 promilles and a deposit of 100 will mean that 5 is the acceptable differencethen, we just check if the difference is GTE the acceptable difference