Event stats #192
Merged
Event stats #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samparsky
force-pushed
the
eventStats
branch
3 times, most recently
from
4f6c3ca
to
e804f1a
Compare
Ivshti
approved these changes
Aug 4, 2019
| const updateChannelPrice = async ev => { | ||
| const price = ev.type === 'UPDATE_IMPRESSION_PRICE' ? ev.price : '0' | ||
| await channelsCol.updateOne({ id: channelId }, { $set: { currentPricePerImpression: price } }) | ||
| if (ev.type === eventTypes.IMPRESSION_PRICE_PER_CASE) { |
There was a problem hiding this comment.
later improvement: consider merging IMPRESSION_PRICE_PER_CASE and UPDATE_IMPRESSION_PRICE into one event (considering that this is still not frozen in spec)
There was a problem hiding this comment.
Ohh okay, which event name should it be UPDATE_IMPRESSION_PRICE ?
There was a problem hiding this comment.
Yes, but start with a PR to the documentation with the proposed interface
| // for the event stat | ||
| // it can be publisher prefixed for a specific publisher | ||
| const result = channel.pricePerImpressionCase.find( | ||
| priceCase => priceCase.stat === ev.stat || priceCase.stat === `${ev.publisher}:${ev.stat}` |
There was a problem hiding this comment.
this allows setting the price per-publisher, right?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190 and #191