Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-channel analytics should require auth, fixes #287 #288

Merged
merged 4 commits into from
Jun 12, 2020
Merged

Conversation

Ivshti
Copy link
Member

@Ivshti Ivshti commented Jun 12, 2020

The channel analytics now require that the channel creator (advertiser) authenticates.

This fixes 3 distinct issues:

  • analytics: channel-level stats should require auth #287: advertiser analytics per channel must require auth
  • calling this path with authentication actually caused earning (publisher) stats to be retrieved for this channel - leading to zero results for almost all channels except the one where the creator is both an advertiser and publisher
  • calling this path with authentication will cause it to be cached in the same cache key as every other call to it, leading to results for different callers being served

@Ivshti Ivshti requested a review from samparsky June 12, 2020 10:03
@Ivshti Ivshti merged commit ec29925 into master Jun 12, 2020
@Ivshti Ivshti deleted the analytics-auth branch June 12, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants