submit channel #64
Merged
submit channel #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samparsky
changed the title
samparsky
changed the title
samparsky
force-pushed
the
api-channel-info
branch
2 times, most recently
from
9a007fd
to
f058c6a
Compare
Ivshti
changed the title
Ivshti
requested changes
Feb 23, 2019
samparsky
force-pushed
the
api-channel-info
branch
2 times, most recently
from
865ec8d
to
929c2b4
Compare
samparsky
force-pushed
the
api-channel-info
branch
from
929c2b4
to
383fba6
Compare
samparsky
force-pushed
the
api-channel-info
branch
2 times, most recently
from
c039721
to
0e33db9
Compare
samparsky
force-pushed
the
api-channel-info
branch
from
0e33db9
to
896be7e
Compare
Ivshti
requested changes
Mar 23, 2019
routes/channel.js
Outdated
| @@ -115,6 +125,27 @@ function getValidatorMessages(req, res, next) { | |||
| .catch(next) | |||
| } | |||
|
|
|||
| function createCampaign(req, res, next) { | |||
There was a problem hiding this comment.
rename this, as well as the routes, to createChannel and POST /channel
Ivshti
requested changes
Mar 24, 2019
routes/schema.js
Outdated
| return schema | ||
| } | ||
|
|
||
| function validators({ CREATORS_WHITELIST }) { |
There was a problem hiding this comment.
also, other than VALIDATORS_WHITELIST (separate thing than CREATORS_WHITELIST), this should check if the validator count is always 2; not larger, not smaller, always === 2
and when checking the whitelist, we should check VALIDATORS_WHITELIST OR === adapter.whoami()
There was a problem hiding this comment.
yeah it already checks the validator count is always 2.
samparsky
force-pushed
the
api-channel-info
branch
from
599ef5b
to
3e2ba49
Compare
Ivshti
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issues #44 #30