Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ Address Book #663

Merged
merged 24 commits into from
Mar 28, 2024
Merged

Feature/ Address Book #663

merged 24 commits into from
Mar 28, 2024

Conversation

PetromirDev
Copy link
Member

@PetromirDev PetromirDev commented Mar 21, 2024 •
edited

Changes:

  • Add: addressBook controller
  • Add: addressBook controller tests

More info in and linked with:

https://github.com/AmbireTech/ambire-app/pull/1937

@PetromirDev PetromirDev added the enhancement New feature or request label Mar 21, 2024
@PetromirDev PetromirDev self-assigned this Mar 21, 2024
@PetromirDev PetromirDev changed the title Feature/ Address Book WIP: Feature/ Address Book Mar 22, 2024
@PetromirDev PetromirDev changed the title WIP: Feature/ Address Book Feature/ Address Book Mar 26, 2024
@PetromirDev PetromirDev marked this pull request as ready for review March 26, 2024 11:16
@superKalo
Copy link
Member

Please make sure the tests pass before merging this. I saw one falling from the address book ones that you added:

FAIL src/controllers/addressBook/addressBook.test.ts

@PetromirDev PetromirDev merged commit 64abedb into v2 Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superKalo superKalo superKalo approved these changes

Assignees

@PetromirDev PetromirDev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@PetromirDev @superKalo