Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/custom networks improvements #675

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Feature/custom networks improvements #675

merged 2 commits into from
Mar 28, 2024

Conversation

borislav-itskov
Copy link
Member

@borislav-itskov borislav-itskov commented Mar 28, 2024 •
edited

Change log:

  • add hasSingleton to networkInfo
  • use hasSingleton to determine whether the reason for sa failure is because there's no singleton on the network the RPC is bad. Change the tooltip message in accordance
  • shorten long error message sometimes shown on a failed broadcast

Also, write a test for the above case

@borislav-itskov borislav-itskov added the enhancement New feature or request label Mar 28, 2024
@borislav-itskov borislav-itskov merged commit a499f98 into v2 Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonytooo sonytooo sonytooo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@borislav-itskov @sonytooo