Update ColumnLimit to 120 #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A ColumnLimit of 180 is far to big. - Definitions in Headers or method calls with several parameters with several non trivial types get over that fast. - horizontal scrolling is a pain - Not everybody has an 2k or 4k monitor (me) but just HD (me and others) some have on their Laptop even smaller resolutions, due to the small screens, if no monitor is available (not me, but I know colleagues) this is however a minority. - Our python format definition is 111. But it seems that this option shall be as big as possible. Compromise: On a HD monitor in standard font size in several IDEs in default window/widget configuration (VS code, Intellij) the line ends between Column 120 and 130. So I propose a ColumnLimit of 120.
bibermann
requested changes
Nov 17, 2021
|
We have coding guidelines in Ambrosys for that. For C++ we use the google style: https://google.github.io/styleguide/cppguide.html#Line_Length |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ColumnLimit of 180 is far to big.
But it seems that this option shall be as big as possible.
Compromise: On a HD monitor in standard font size in several IDEs in default window/widget configuration (VS code, Intellij) the line ends between Column 120 and 130.
So I propose a ColumnLimit of 120.