Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/208 Delete Enrollment/s Not Found #245

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

TharunKumarReddyPolu
Copy link
Member

Description:

Fixed the Issue DEL /enrollments - 'Enrollment/s Not Found' is missing with implementing a choice in the .xml flow as follows:

  1. Success flow: If post delete payload's successful flag is true, then return status code as 200 OK
  2. Error flow: If post delete payload's size with filter(no. of items with item.successful is false) and without filter are same, then return status code as 404 Not Found
  3. Partial Success flow: Else Case of above, then return status code as 206 Partial Content
  • Update the flow endpoint in the RAML file src/main/resources/api/salesforce-data-api.raml
  • Document the changes to the RAML file in docs/raml_changes
  • Update the flow in the related .xml file
  • Update the flow into the Postman collection
  • Test the new flow locally using Postman or Thunder (for testing, don't forget to point to local RAML in src/main/mule/global.xml: api="salesforce-data-api.raml").
  • Push the changes and create a pull request (PR)
  • When merging, update the RAML file in Exchange

Test Example:

DELETE {{base_url}}/enrollments

Payload 1:

[
  {
      "EnrollmentId": "a0mU8000000hMzlIAE"
  }
]

Payload 2:

[
  {
      "EnrollmentId": "a0mU8000000hMy9IAE"
  }
]

Payload 3:

[
    {
        "EnrollmentId": "a0mU8000000hN1NIAU"
    },
    {
        "EnrollmentId": "a0mU8000000hMzlIAE"
    }
]

Screenshots of Tests:

Payload 1:

image

Payload 2:

image

Payload 3:

image

Copy link
Sponsor Member

@CritiqalPete CritiqalPete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks verbosity appreciated =)

@CritiqalPete CritiqalPete merged commit 48823ac into sandbox Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEL /enrollments - 'Enrollment/s Not Found' is missing
2 participants