This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Removes extra padding and height to the wayfinder. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wayfinder expands as needed
froboy
reviewed
Dec 20, 2017
| @@ -11,12 +11,20 @@ | |||
| Drupal.behaviors.wayfinder = { | |||
| attach: function (context, settings) { | |||
| (function ($) { | |||
|
|
|||
| var pageTitle = document.title.replace(' | AMA', ''); | |||
There was a problem hiding this comment.
@designerneil this looks like it's the debugging code you mention in the testing instructions? Also the console.log line shouldn't be committed.
There was a problem hiding this comment.
good catch. It's been removed. Thanks
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
Please do not submit a Pull Request without a relevant ticket! If you are creating a new pattern or feature, create an issue describing the need for this feature Github first and then link to it below.
Github Issue
Does not have a linked to story because Jira is down!
Description
To Test
var pageTitle = document.title.replace(' | AMA', ''); var pageUrl = window.location.href; $.cookie.json = true; $.cookie('ama_wayfinder_cookie', [pageTitle, pageUrl], { expires: 1, path: '/'});don't commit it.
Relevant Screenshots/GIFs
Remaining Tasks
This needs to get tested in D8
Additional Notes
The wayfinder will not show unless there is a cookie called ama_wayfinder.