Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legends button doesn't work #232

Open
yeahphil opened this issue Jul 28, 2021 · 6 comments · Fixed by #235
Open

Legends button doesn't work #232

yeahphil opened this issue Jul 28, 2021 · 6 comments · Fixed by #235

Comments

@yeahphil
Copy link
Collaborator

There's a legends view that's supposed to be displayed when you tap the info button at upper left on the runs list controller. Rough screenshot attached. This doesn't work right now because it's behind the table view so is hidden by it.

Is this supposed to appear?

image

@Gregliest
Copy link
Contributor

Yeah that's a bug.

@Gregliest Gregliest added this to In progress in iOS App Enhancements Aug 5, 2021
yeahphil added a commit that referenced this issue Aug 6, 2021
This presented the legend view, which was removed in #233

Fixes #232
Gregliest pushed a commit that referenced this issue Aug 6, 2021
…235)

This presented the legend view, which was removed in #233

Fixes #232
@Gregliest Gregliest moved this from In progress to Ready for Test in iOS App Enhancements Aug 6, 2021
@AWKevin
Copy link

AWKevin commented Aug 10, 2021

This does not appear to be fixed. I don't see the Legend with I click the 'I" in the upper left corner of the runs list. When clicked, nothing happens. As far as I can tell there is no legend anywhere describing what the colors mean.

@AWKevin AWKevin moved this from Ready for Test to In progress in iOS App Enhancements Aug 10, 2021
@AWKevin AWKevin reopened this Aug 10, 2021
@Gregliest Gregliest moved this from In progress to Ready for Test in iOS App Enhancements Sep 29, 2021
@AWKevin
Copy link

AWKevin commented Sep 30, 2021

Now I can't see the little "I" anywhere. Is it now behind the "Last Updated Bar?" I searched all pages I could think of to find a legend to describe the colors and could not find one.

@AWKevin AWKevin reopened this Sep 30, 2021
@AWKevin AWKevin moved this from Ready for Test to In progress in iOS App Enhancements Sep 30, 2021
@Gregliest
Copy link
Contributor

We ended up removing this, do you think it's important to add back?

@AWKevin
Copy link

AWKevin commented Sep 30, 2021

Yes it is very important IMO. We have color coded flow readings on the App but nothing to tell visitors what that means. Just as importantly when you boil down the AW value-add to what else is out there it is our info on what levels are good or not good. I think anywhere there is color-coded flow info we should provide access to a legend.

@Gregliest
Copy link
Contributor

@yeahphil If you've got time, would you mind tackling this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
iOS App Enhancements
  
In progress
Development

Successfully merging a pull request may close this issue.

3 participants