Refresh still broken #265
Assignees
Labels
Comments
|
Lol where is that "Refreshing..." string coming from? I thought we removed it |
|
@Gregliest is it possible the TF build didn't have 4e79a1a merged yet? The string "Refreshing..." doesn't appear anywhere in the app source or storyboards any more |
yeahphil
added a commit
that referenced
this issue
Sep 30, 2021
This is a kludge that maybe makes #265 part 2 less noticeable
|
Haha that's possible, I'll cut a new build once we get these fixes in.
…On Thu, Sep 30, 2021 at 4:07 PM Phillip Kast ***@***.***> wrote:
@Gregliest <https://github.com/Gregliest> is it possible the TF build
didn't have 4e79a1a
<4e79a1a>
merged yet? The string "Refreshing..." doesn't appear anywhere in the app
source or storyboards any more
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#265 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCI7Z7IGAE3OMFNDIP2LHLUETUSRANCNFSM5FC3GISQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Gregliest
pushed a commit
that referenced
this issue
Oct 5, 2021
* Oops, fix bounds checking wrong thing in RunDetailTableViewController.updateImagePreviews() See https://console.firebase.google.com/u/1/project/american-whitewater-1234/crashlytics/app/ios:org.americanwhitewater.aw/issues/a8f7361272c0a9c9c4b3250363c6ae35?time=last-seven-days&versions=1.4.0%20(2)&sessionEventKey=e805326fff5e46829f79384bc7339b58_1592225718857010802 * Hide the refresh control on viewWillAppear if it's already animating. This is a kludge that maybe makes #265 part 2 less noticeable * Revert "Hide the refresh control on viewWillAppear if it's already animating." This reverts commit dc4f64f. Co-authored-by: Gregory Lee <git@gregliest.com>
|
We are going to punt on 2) until the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@yeahphil I've gotten the refresh controller in a couple of bug states.
On first run, the last updated time didn't update, and the bar showed the text "Refreshing..." (see photo). I was clicking around and came back to the page after it had finished loading.
If you pull to refresh, click on another tab like favorites, and come back to the list, the spinner will be at the top but not spinning. It does seem to go away after a while, which is I assume when the request finishes.
.
The text was updated successfully, but these errors were encountered: