Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: Multi-selection for journals #34

Merged
merged 13 commits into from
Jun 9, 2023
Merged

Added: Multi-selection for journals #34

merged 13 commits into from
Jun 9, 2023

Conversation

AmmarAbouZor
Copy link
Owner

@AmmarAbouZor AmmarAbouZor commented Jun 9, 2023 •
edited

This PR closes #7

The following was added:

  • A new multi-select mode (with v keybinding) for journals with the following functions:
  1. Toggle selection for the current journal with space enter <Ctrl-m>
  2. Select all journals with a
  3. Select none with x
  4. Invert selection with i
  • A delete function inside the multi-select mode to delete many journals at once d
  • A new tab in the help popup where the keybindings are explained
  • Adjustments on the footer to show the important keybindings when multi-select mode is active
  • Fixes for small mistakes regarding discarding the journal after the save prompt

@AmmarAbouZor
Multi Selection: start...
6f91fc5 
- Create commands with description and keybindings
- Integrate commands and keybindings in system
- Add multi selection flag to entries list
@AmmarAbouZor
Implement multi-select commands in app structure
bb6888f
@AmmarAbouZor
Add multi selection keybindings to help popup
373cd0c
@AmmarAbouZor
Build Multi-Select mode in the app...
c1b7965 
- Build keybindings in main handling input routine
- Add more keybindings since the routine will terminate after checking
  this mode bindings
- Adjustments on the styles and texts in entries list
@AmmarAbouZor
Select the corresponding tab when help popup opens
1ff5f5c 
- Multi select tab will be chosen of the help is called while
  multi-select mode is on
@AmmarAbouZor
Adjust footer content when multi select is active
921de76
@AmmarAbouZor
Fix display output for Space-bar key in help popup
06f06ac
@AmmarAbouZor
Fix issues regarding discarding unsaved changes
40c919d 
- Explicit discarding will be performed after answering save dialog with
  no in both commands 'enter multi select mode' and 'export entry
  content'
@AmmarAbouZor
Add unsaved prompt before start editing an entry
c460bad
@AmmarAbouZor
Multi Select: Add delete selected entries command
2983d45
@AmmarAbouZor
Change entries list place holder text with multi-select
cf4d0ae
@AmmarAbouZor
Fix typos
cefcbeb
@AmmarAbouZor
Update README
08923cd
@AmmarAbouZor AmmarAbouZor merged commit ef74ce4 into main Jun 9, 2023
3 checks passed
@AmmarAbouZor AmmarAbouZor deleted the multi_selection branch June 9, 2023 07:09
@AmmarAbouZor AmmarAbouZor mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Multi-selection for journals
1 participant
@AmmarAbouZor