Fix for bug that causes the section header to be left behind when scrolling down. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timominous it definitely fixes the section header placement, however there's a different bug now. If you scroll down, the tableview bounces back, but when you scroll up, it does not, in fact it just stops once the user stops flicking up. Anyway to get it to bounce instead? |
|
I'm not sure if i want to merge this as it removes one bug and introduces another. The section headers are positioned correctly but the scrolling is dodgy, even without section headers. What do you guys think? |
|
I have noticed the bug as well. I haven't tested it thoroughly with large sized headers that's why I overlooked this. Maybe you shouldn't pull this as of now. I am still thinking on how to restore the bouncing effect. Any ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.