Adding support for TOML configuration files #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
README complete. Let me know if there is anything that needs to be updated/refactored |
|
@ijacobs-cpa Thanks for the Pull Request, the coding part looks good. I just put some notes for minor changes to the README file. |
Amnish04
requested changes
Oct 6, 2023
|
Updated the README as asked. Let me know if there is anything else |
|
Looks good, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10
I have added support for TOML files in your project using tomli as requested in #10. Using
-cor--configwith a valid.tomlconfig file will add any supported properties to the converted HTML.For example:
python til-builder_main.py ../examples/ --config ../config.toml:Will convert any txt or md files in the examples folder to HTML with the configurations specified in the
config.tomlfile:If the contents of the TOML file are invalid or the file path does not exist it raises an exception and ends the program. Any attributes provided in the TOML file that are not currently supported by the program will be ignored.
I'll mark this pull request as ready to review once I finish testing and updating the README.