Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FlutterActivity with general Activity #211

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JortdeBokx
Copy link

Replace the reference to FlutterActivity with it's parent class android.Activity
This was an issue when using a FlutterFragmentActivity instead of a FlutterActivity

Solves #128

@octaviodivy
Copy link

Will it be merged?

@Alvarenga1
Copy link

Issue is still present on the latest, I assume it is because this hasn't been merged ?

@lohhans
Copy link

lohhans commented Sep 24, 2021

Owner should accept this PR, I faced the same issue (#128) and using this package locally with this modification worked like a charm! Please @AmolGangadhare, accept this, the package on pub.dev must be updated. 😊

@CarloDotLog
Copy link

Hi @AmolGangadhare, are there any update about this PR?
I've tried it with FlutterActivity and FlutterFragmentActivity and everything works right.

Could you please merge this PR with base branch and release an update to pub.dev?

Thank you.

@eaedev
Copy link

eaedev commented Dec 21, 2021

Owner should accept this PR, I faced the same issue (#128) and using this package locally with this modification worked like a charm! Please @AmolGangadhare, accept this, the package on pub.dev must be updated. 😊

Could you please share how did you fixed? Or maybe fork it until @AmolGangadhare accept it as a solution?

Thank you in advance!

@myfknoll
Copy link

Please merge

@lucas404x
Copy link

Is there any plan to make a fork? I think the project is abandoned.

@khanahsan
Copy link

any update will it be merged? Still face same issue.

@alemurillo104
Copy link

We need a faster solution please...
Waiting this PR to be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet