Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install on mojave #1

Merged
merged 12 commits into from
Jan 7, 2019
Merged

Fix install on mojave #1

merged 12 commits into from
Jan 7, 2019

Conversation

convenient
Copy link
Contributor

There were two header issues which prevented PHP being compiled on the latest OSX mojave.

Firstly apple changed how their headers were handled. (emphasis mine)

https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes

The command line tools will search the SDK for system headers by default. However, some software may fail to build correctly against the SDK and require macOS headers to be installed in the base system under /usr/include. If you are the maintainer of such software, we encourage you to update your project to work with the SDK or file a bug report for issues that are preventing you from doing so. As a workaround, an extra package is provided which will install the headers to the base system. In a future release, this package will no longer be provided. You can find this package at:

/Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg

Secondly there was a bug in the PHP src with how it handled includes itself.

php/php-src#3472

This PR is largely a port of what was done in the homebrew-core here Homebrew/homebrew-core@edf393e

@convenient convenient merged commit 69c4030 into master Jan 7, 2019
@convenient convenient deleted the fix-install-on-mojave branch January 7, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant