Fix/source repository tests #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convenient
commented
May 25, 2023
| public function getTableName(int $stockId): string | ||
| { | ||
| - return 'reservations_temp_for_stock_' . $stockId; | ||
| + return $this->resourceConnection->getTableName('reservations_temp_for_stock_' . $stockId); |
There was a problem hiding this comment.
Handles table prefixes, affects integration tests in as all tables are prefixed there. Broken for 2.4.4 series.
convenient
commented
May 25, 2023
| * @dataProvider sourcesDataProvider | ||
| * | ||
| * @magentoDataFixture Magento_InventorySalesApi::Test/_files/websites_with_stores.php |
There was a problem hiding this comment.
Reorder so this is the first applied, and last to roll back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO - Squash merge this PR
Some improvements for the test running on this branch.
trv_. I want to keep the versions under test as clear as possible, but this wont affect most use cases and will allow us to get the tests going through