Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 1 #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Patch 1 #64

wants to merge 3 commits into from

Conversation

bhamblok
Copy link

No description provided.

Bob Hamblok added 2 commits June 18, 2015 12:47
Calling toJSON-func of child-models in stead of theirs serialize-func…
85d6af8 
… during the collections serialize-func

When calling the toJSON-func of a collection, it actually calls the serialize-func. This allows you to overwrite the toJSON-func... 
The resulting object contains the "serialize"-function result of its Child-models. It would be better if all of their toJSON-functions would be used.
added test
c8eaafe
@pgilad
Copy link
Member

pgilad commented Jun 18, 2015

Hey thanks for adding the test, but what I would expect the test to validate is that by changing serialize to toJSON for child-models you get the same output. What you checked for is that the toJSON function was called

@bhamblok
Copy link
Author

Hi @pgilad, thanks for the quick follow up. I think I've got it right, right now.

@pgilad
Copy link
Member

pgilad commented Jun 18, 2015

🍎 +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhamblok @pgilad