add fix for how amp sync treats error callbacks #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any ETA on merging this? Causing a ton of issues with some apps we have |
|
+1, fix looks good to me. I'll find another @AmpersandJS/core-team person to second this and we'll get it merged/published. |
|
+1 do it @lukekarrys |
|
What's the process for merging PRs? Documented anywhere? Seems a tad slow to wait for the whole team to chime in on a simple two line bug fix that includes tests |
|
published as Thanks @engenb! @contra the typical process we have is 2 plus ones: http://ampersandjs.com/learn/bug-triage-process#pull-requests |
|
We're also in the process of assigning lead maintainers for each repo so it's clearer who's the primary on each one. |
This was referenced Aug 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request addresses #38