New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a failing test for problem described in #146. No solution, yet. #147

Open

HenrikJoreteg wants to merge 1 commit into master from consistent-parse

Member

HenrikJoreteg commented Feb 26, 2015

To help state the problem in the form of test.


          a failing test for problem described in #146. No solution, yet.

a86af8a

Contributor

kamilogorek commented Feb 27, 2015

I guess those tests won't work like we'd expect, because they'll give us false positive:

- this[coll] = new this._collections[coll](null, {parent: this});
+ this[coll] = new this._collections[coll](null, {parent: this, parse: true});

- this[child] = new this._children[child]({}, {parent: this});
+ this[child] = new this._children[child]({}, {parent: this, parse: true});

This change itself will fix the tests, but as we initialize those things as an empty, in the end nothing gets parsed.

bear added bug test request labels

kamilogorek mentioned this pull request

Fixed outstanding collections/children parsing tests. FIX #147 #209

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment