Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safeSet for children & collections #192

Merged
merged 1 commit into from
Sep 3, 2015
Merged

Conversation

pgilad
Copy link
Member

@pgilad pgilad commented Aug 26, 2015

@kamilogorek
Copy link
Contributor

Are we sure that we want to throw when it happens instead of just inform dev?

@pgilad
Copy link
Member Author

pgilad commented Aug 26, 2015

My thoughts are that if you're doing something wrong (which will cause errors down the line), throw loudly. I'd rather have that than a console.log.

@cdaringe
Copy link
Member

cdaringe commented Sep 2, 2015

+1

1 similar comment
@lukekarrys
Copy link
Contributor

+1

cdaringe added a commit that referenced this pull request Sep 3, 2015
Add safeSet for children & collections
@cdaringe cdaringe merged commit d734189 into master Sep 3, 2015
@cdaringe cdaringe deleted the feature/safe-set branch September 3, 2015 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants