Fixed bug where model ajaxConfig.beforeSend could be ignored

[tomasztunik]

Check for xhrFields on the ajaxConfig and override for beforeSend were overshadowing referencing beforeSend from the ajaxConfig on the params object and beforeSend was ignored if xhrFields was undefined.

[tomasztunik]

Also a thought about beforeSend - in the xhrFields block you apply with this (sync) as context - wouldn't be it more valuable and useful to apply and bind to the model so that model data is accessible in the beforeSend? or alternatively accept model as second argument as currently I would have to bind or wrap beforeSend in model initialize method to be able to have access to the model instance from beforeSend method.

[tomasztunik]

fixes #17

[kamilogorek]

lgtm +1

[wraithgar]

Does this mean that xhrFields and beforeSend are mutually exclusive now?

[tomasztunik]

with this fix beforeSend still gets called when xhrFields are provided -
check L87 in ampersand-sync.js - so they are not mutually exclusive.

On Mon Nov 10 2014 at 7:09:43 PM Michael Garvin notifications@github.com
wrote:

Does this mean that xhrFields and beforeSend are mutually exclusive now?

—
Reply to this email directly or view it on GitHub
#23 (comment)
.

[wraithgar]

Perfect thank you @tomasztunik I missed that last read through.

+1 and thanks for including the test

[tomasztunik]

no problem - ended up not needing it in the end but might save some trouble
somebody else in the future :)

On Mon Nov 10 2014 at 8:10:46 PM Michael Garvin notifications@github.com
wrote:

Perfect thank you @tomasztunik https://github.com/tomasztunik I missed
that last read through.

+1 and thanks for including the test

—
Reply to this email directly or view it on GitHub
#23 (comment)
.