Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events hash cannot contain actual functions #37

Closed
latentflip opened this issue Aug 6, 2014 · 3 comments · Fixed by #106
Closed

Events hash cannot contain actual functions #37

latentflip opened this issue Aug 6, 2014 · 3 comments · Fixed by #106
Labels

Comments

@latentflip
Copy link
Contributor

This doesn't actually work:

events: {
  'click .something': function () { /*do something here*/ }

Because the event mixin tries to lookup the callback on the view by name, without checking if it's already a function: https://github.com/HenrikJoreteg/events/blob/master/index.js#L81

Related:
#38

@jrmyio
Copy link
Contributor

jrmyio commented Sep 9, 2014

Took me a while before I was sure I wasn't doing anything wrong.

Can this please be merged?

@dminkovsky
Copy link
Contributor

Yes, +1 here. The docs are currently lying!

@bear bear added the bug label Oct 31, 2014
@ben-eb
Copy link

ben-eb commented Jan 27, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants